Bug 171874

Summary: Move onanimation* EventHandlers to GlobalEventHandlers
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cmarcelo, commit-queue, dbates, esprehn+autocc, ggaren, kangil.han, kondapallykalyan, rniwa, sam, simon.fraser
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://drafts.csswg.org/css-animations/#interface-globaleventhandlers-idl
Attachments:
Description Flags
WIP Patch
none
Patch
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Patch none

Chris Dumez
Reported 2017-05-09 12:09:36 PDT
Move onanimation* EventHandlers to GlobalEventHandlers to match the specification: - https://drafts.csswg.org/css-animations/#interface-globaleventhandlers-idl We currently have those on Window and Element only.
Attachments
WIP Patch (7.55 KB, patch)
2017-05-09 12:18 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (14.32 KB, patch)
2017-05-09 12:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (30.77 MB, application/zip)
2017-05-09 14:17 PDT, Build Bot 		no flags
Details
Patch (16.75 KB, patch)
2017-05-09 14:19 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-05-09 12:18:14 PDT
Created attachment 309520 [details] WIP Patch
Chris Dumez
Comment 2 2017-05-09 12:41:28 PDT
Created attachment 309523 [details] Patch
Build Bot
Comment 3 2017-05-09 14:17:00 PDT
Comment on attachment 309523 [details] Patch Attachment 309523 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3707301 New failing tests: fast/dom/event-handler-attributes.html imported/w3c/web-platform-tests/streams/readable-byte-streams/general.html
Build Bot
Comment 4 2017-05-09 14:17:02 PDT
Created attachment 309537 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Chris Dumez
Comment 5 2017-05-09 14:19:44 PDT
Created attachment 309539 [details] Patch
Chris Dumez
Comment 6 2017-05-09 14:21:09 PDT
Comment on attachment 309539 [details] Patch Clearing flags on attachment: 309539 Committed r216540: <http://trac.webkit.org/changeset/216540>
Chris Dumez
Comment 7 2017-05-09 14:21:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.