Bug 171874 - Move onanimation* EventHandlers to GlobalEventHandlers
Summary: Move onanimation* EventHandlers to GlobalEventHandlers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://drafts.csswg.org/css-animatio...
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2017-05-09 12:09 PDT by Chris Dumez
Modified: 2017-05-09 14:21 PDT (History)
11 users (show)

See Also:


Attachments
WIP Patch (7.55 KB, patch)
2017-05-09 12:18 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (14.32 KB, patch)
2017-05-09 12:41 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (30.77 MB, application/zip)
2017-05-09 14:17 PDT, Build Bot
no flags Details
Patch (16.75 KB, patch)
2017-05-09 14:19 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-05-09 12:09:36 PDT
Move onanimation* EventHandlers to GlobalEventHandlers to match the specification:
- https://drafts.csswg.org/css-animations/#interface-globaleventhandlers-idl

We currently have those on Window and Element only.
Comment 1 Chris Dumez 2017-05-09 12:18:14 PDT
Created attachment 309520 [details]
WIP Patch
Comment 2 Chris Dumez 2017-05-09 12:41:28 PDT
Created attachment 309523 [details]
Patch
Comment 3 Build Bot 2017-05-09 14:17:00 PDT
Comment on attachment 309523 [details]
Patch

Attachment 309523 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3707301

New failing tests:
fast/dom/event-handler-attributes.html
imported/w3c/web-platform-tests/streams/readable-byte-streams/general.html
Comment 4 Build Bot 2017-05-09 14:17:02 PDT
Created attachment 309537 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 5 Chris Dumez 2017-05-09 14:19:44 PDT
Created attachment 309539 [details]
Patch
Comment 6 Chris Dumez 2017-05-09 14:21:09 PDT
Comment on attachment 309539 [details]
Patch

Clearing flags on attachment: 309539

Committed r216540: <http://trac.webkit.org/changeset/216540>
Comment 7 Chris Dumez 2017-05-09 14:21:11 PDT
All reviewed patches have been landed.  Closing bug.