Bug 171869

Summary: Remove user agent quirk for Slack
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, buildbot, cgarcia, mcatanzaro
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
cgarcia: review+, buildbot: commit-queue-
Archive of layout-test-results from ews123 for ios-simulator-wk2 none

Michael Catanzaro
Reported 2017-05-09 11:29:07 PDT
The user agent quirk for Slack does not seem to be necessary anymore. I am able to use Slack without difficulty using our default user agent. The quirk is not causing any harm, so there's no need to backport this to stable just in case I've messed up, but we should not retain quirks in trunk when they are no longer necessary.
Attachments
Patch (1.41 KB, patch)
2017-05-09 11:30 PDT, Michael Catanzaro 		cgarcia: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (841.43 KB, application/zip)
2017-05-09 12:43 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2017-05-09 11:30:45 PDT
Created attachment 309517 [details] Patch
Build Bot
Comment 2 2017-05-09 12:43:10 PDT
Comment on attachment 309517 [details] Patch Attachment 309517 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3706904 New failing tests: imported/w3c/web-platform-tests/streams/readable-byte-streams/general.html
Build Bot
Comment 3 2017-05-09 12:43:11 PDT
Created attachment 309525 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Carlos Garcia Campos
Comment 4 2017-05-10 00:36:05 PDT
Comment on attachment 309517 [details] Patch Don't we have a unit tests checking this quirk too?
Michael Catanzaro
Comment 5 2017-05-10 07:47:49 PDT
Yup, good catch
Michael Catanzaro
Comment 6 2017-05-10 07:50:06 PDT
Committed r216585: <http://trac.webkit.org/changeset/216585>
Note You need to log in before you can comment on or make changes to this bug.