Bug 171845

Summary: Update DocumentOrShadowRoot.idl to match specifications
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, dbates, esprehn+autocc, kangil.han, kondapallykalyan, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Attachments
Patch (4.31 KB, patch)
2017-05-08 21:09 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-05-08 21:09:02 PDT
Created attachment 309464 [details] Patch
Ryosuke Niwa
Comment 2 2017-05-08 21:15:57 PDT
Comment on attachment 309464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309464&action=review > Source/WebCore/dom/Document.idl:106 > + // FIXME: Should likely be moved to DocumentOrShadowRoot. Not sure if "likely" is necessary given the current spec says so. We can remove the comment if we change the spec.
Chris Dumez
Comment 3 2017-05-08 21:17:43 PDT
Comment on attachment 309464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309464&action=review >> Source/WebCore/dom/Document.idl:106 >> + // FIXME: Should likely be moved to DocumentOrShadowRoot. > > Not sure if "likely" is necessary given the current spec says so. We can remove the comment if we change the spec. Well, my issue is that https://w3c.github.io/webcomponents/spec/shadow/#extensions-to-the-documentorshadowroot-mixin & https://drafts.csswg.org/cssom/#extensions-to-the-document-interface disagree.
Ryosuke Niwa
Comment 4 2017-05-08 21:22:51 PDT
(In reply to Chris Dumez from comment #3) > Comment on attachment 309464 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309464&action=review > > >> Source/WebCore/dom/Document.idl:106 > >> + // FIXME: Should likely be moved to DocumentOrShadowRoot. > > > > Not sure if "likely" is necessary given the current spec says so. We can remove the comment if we change the spec. > > Well, my issue is that > https://w3c.github.io/webcomponents/spec/shadow/#extensions-to-the- > documentorshadowroot-mixin & > https://drafts.csswg.org/cssom/#extensions-to-the-document-interface > disagree. Oh I see.
WebKit Commit Bot
Comment 5 2017-05-09 08:04:16 PDT
Comment on attachment 309464 [details] Patch Clearing flags on attachment: 309464 Committed r216506: <http://trac.webkit.org/changeset/216506>
WebKit Commit Bot
Comment 6 2017-05-09 08:04:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.