| Summary: | Modernize WebKit2 code | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, simon.fraser | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alex Christensen
2017-05-08 14:45:57 PDT
Created attachment 309416 [details]
Patch
Comment on attachment 309416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309416&action=review r=me > Source/WebKit2/UIProcess/WebPageProxy.cpp:3045 > + Function<void(CallbackBase::Error)> didForceRepaintCallback = [this, callback = WTFMove(callback)](CallbackBase::Error error) mutable { Could use auto no ? Comment on attachment 309416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309416&action=review > Source/WebKit2/ChangeLog:3 > + Modernize WebKit2 code Modernize how? A bit more detail would be nice. Created attachment 309434 [details]
Patch
(In reply to Chris Dumez from comment #2) > Comment on attachment 309416 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309416&action=review > > r=me > > > Source/WebKit2/UIProcess/WebPageProxy.cpp:3045 > > + Function<void(CallbackBase::Error)> didForceRepaintCallback = [this, callback = WTFMove(callback)](CallbackBase::Error error) mutable { > > Could use auto no ? No, for some reason that causes a compiler error. Something about constructors and lambdas and copies. Created attachment 309445 [details]
Patch
|