Bug 171831

Summary: Modernize WebKit2 code
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2017-05-08 14:45:57 PDT
Modernize WebKit2 code
Attachments
Patch (50.63 KB, patch)
2017-05-08 14:49 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (50.93 KB, patch)
2017-05-08 16:12 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (51.78 KB, patch)
2017-05-08 17:24 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-05-08 14:49:23 PDT
Created attachment 309416 [details] Patch
Chris Dumez
Comment 2 2017-05-08 14:54:33 PDT
Comment on attachment 309416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309416&action=review r=me > Source/WebKit2/UIProcess/WebPageProxy.cpp:3045 > + Function<void(CallbackBase::Error)> didForceRepaintCallback = [this, callback = WTFMove(callback)](CallbackBase::Error error) mutable { Could use auto no ?
Simon Fraser (smfr)
Comment 3 2017-05-08 14:55:02 PDT
Comment on attachment 309416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309416&action=review > Source/WebKit2/ChangeLog:3 > + Modernize WebKit2 code Modernize how? A bit more detail would be nice.
Alex Christensen
Comment 4 2017-05-08 16:12:50 PDT
Created attachment 309434 [details] Patch
Alex Christensen
Comment 5 2017-05-08 16:13:46 PDT
(In reply to Chris Dumez from comment #2) > Comment on attachment 309416 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309416&action=review > > r=me > > > Source/WebKit2/UIProcess/WebPageProxy.cpp:3045 > > + Function<void(CallbackBase::Error)> didForceRepaintCallback = [this, callback = WTFMove(callback)](CallbackBase::Error error) mutable { > > Could use auto no ? No, for some reason that causes a compiler error. Something about constructors and lambdas and copies.
Alex Christensen
Comment 6 2017-05-08 17:24:57 PDT
Created attachment 309445 [details] Patch
Alex Christensen
Comment 7 2017-05-08 19:23:02 PDT
http://trac.webkit.org/r216473
Note You need to log in before you can comment on or make changes to this bug.