Summary: | Follow-up to bug 171710: use more references and reject if either audio or video source creation is failing | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
Component: | Media | Assignee: | youenn fablet <youennf> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, commit-queue, eric.carlson, jer.noble, jonlee, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 171849 | ||||||||||||
Attachments: |
|
Description
youenn fablet
2017-05-08 13:27:37 PDT
Created attachment 309406 [details]
Patch
Comment on attachment 309406 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309406&action=review > Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.h:59 > + Vector<CaptureDevice> m_devices; Where is this initialized? Comment on attachment 309406 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309406&action=review >> Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.h:59 >> + Vector<CaptureDevice> m_devices; > > Where is this initialized? It is empty currently. We should probably add mock values and use them within tests. Created attachment 309423 [details]
Trying to fix GTK build
Created attachment 309437 [details]
Trying to fix GTK build 2
Comment on attachment 309437 [details] Trying to fix GTK build 2 View in context: https://bugs.webkit.org/attachment.cgi?id=309437&action=review > Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:83 > + return m_audioFactory ? *m_audioFactory: defaultAudioFactory(); space before colon Created attachment 309466 [details]
Patch for landing
Comment on attachment 309466 [details] Patch for landing Clearing flags on attachment: 309466 Committed r216477: <http://trac.webkit.org/changeset/216477> All reviewed patches have been landed. Closing bug. |