Bug 171824

Summary: Follow-up to bug 171710: use more references and reject if either audio or video source creation is failing
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, eric.carlson, jer.noble, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 171849    
Attachments:
Description Flags
Patch
none
Trying to fix GTK build
none
Trying to fix GTK build 2
none
Patch for landing none

youenn fablet
Reported 2017-05-08 13:27:37 PDT
Follow-up to bug 171710: use more references and reject if either audio or video source creation is failing
Attachments
Patch (22.89 KB, patch)
2017-05-08 13:31 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Trying to fix GTK build (23.12 KB, patch)
2017-05-08 15:56 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Trying to fix GTK build 2 (23.72 KB, patch)
2017-05-08 16:25 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (23.56 KB, patch)
2017-05-08 21:33 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-05-08 13:31:26 PDT
Created attachment 309406 [details] Patch
Radar WebKit Bug Importer
Comment 2 2017-05-08 14:02:57 PDT
<rdar://problem/32058957>
Eric Carlson
Comment 3 2017-05-08 14:18:41 PDT
Comment on attachment 309406 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309406&action=review > Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.h:59 > + Vector<CaptureDevice> m_devices; Where is this initialized?
youenn fablet
Comment 4 2017-05-08 14:23:10 PDT
Comment on attachment 309406 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309406&action=review >> Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.h:59 >> + Vector<CaptureDevice> m_devices; > > Where is this initialized? It is empty currently. We should probably add mock values and use them within tests.
youenn fablet
Comment 5 2017-05-08 15:56:57 PDT
Created attachment 309423 [details] Trying to fix GTK build
youenn fablet
Comment 6 2017-05-08 16:25:11 PDT
Created attachment 309437 [details] Trying to fix GTK build 2
Alex Christensen
Comment 7 2017-05-08 20:09:21 PDT
Comment on attachment 309437 [details] Trying to fix GTK build 2 View in context: https://bugs.webkit.org/attachment.cgi?id=309437&action=review > Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:83 > + return m_audioFactory ? *m_audioFactory: defaultAudioFactory(); space before colon
youenn fablet
Comment 8 2017-05-08 21:33:55 PDT
Created attachment 309466 [details] Patch for landing
WebKit Commit Bot
Comment 9 2017-05-08 22:14:35 PDT
Comment on attachment 309466 [details] Patch for landing Clearing flags on attachment: 309466 Committed r216477: <http://trac.webkit.org/changeset/216477>
WebKit Commit Bot
Comment 10 2017-05-08 22:14:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.