Bug 171816

Summary: Remove black background from video layer while in fullscreen.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: New BugsAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Alternate Patch.
none
Patch for landing. none

Jeremy Jones
Reported 2017-05-08 11:27:58 PDT
Remove black background from video layer while in fullscreen.
Attachments
Patch (3.09 KB, patch)
2017-05-08 11:30 PDT, Jeremy Jones 		eric.carlson: review+
DetailsFormatted DiffDiff
Alternate Patch. (1.76 KB, patch)
2017-05-08 13:54 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch for landing. (3.09 KB, patch)
2017-05-08 18:43 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2017-05-08 11:28:49 PDT
rdar://problem/31770423
Jeremy Jones
Comment 2 2017-05-08 11:30:52 PDT
Created attachment 309385 [details] Patch
Eric Carlson
Comment 3 2017-05-08 12:25:28 PDT
Comment on attachment 309385 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309385&action=review We should have a test for this. You may be able to add a test for this to an existing API tests instead of writing a new test. > Source/WebCore/ChangeLog:11 > + and back to black when it returns to inline to better fascilitate fullsceen animations. Nit: "fascilitate" => "facilitate"
Jeremy Jones
Comment 4 2017-05-08 13:54:33 PDT
Created attachment 309407 [details] Alternate Patch.
Jeremy Jones
Comment 5 2017-05-08 18:43:34 PDT
Created attachment 309457 [details] Patch for landing.
WebKit Commit Bot
Comment 6 2017-05-08 19:00:08 PDT
Comment on attachment 309457 [details] Patch for landing. Clearing flags on attachment: 309457 Committed r216472: <http://trac.webkit.org/changeset/216472>
Note You need to log in before you can comment on or make changes to this bug.