Bug 171813

Summary: Drop [CEReactions] from CharacterData operations
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, cdumez, commit-queue, dbates, esprehn+autocc, ggaren, kangil.han, kling, koivisto, kondapallykalyan, rniwa, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dom.spec.whatwg.org/#interface-characterdata
See Also: https://bugs.webkit.org/show_bug.cgi?id=163969
Bug Depends on: 171688    
Bug Blocks: 154907    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2017-05-08 10:34:55 PDT
Drop [CEReactions] from CharacterData operations to match the DOM specification: - https://dom.spec.whatwg.org/#interface-characterdata I believe WebKit had this because Attr used to have Text child nodes. Therefore, modifying those Text child nodes via the CharacterData API could modify the value of an attribute, requiring us to run attributeChangedCallback for Custom Elements. However, as of Bug 171688, Attr can no longer have Text child nodes. I have also verified that Blink does not have [CEReactions] for those methods.
Attachments
Patch (2.82 KB, patch)
2017-05-08 12:18 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-05-08 12:18:13 PDT
Created attachment 309393 [details] Patch
WebKit Commit Bot
Comment 2 2017-05-08 19:46:29 PDT
Comment on attachment 309393 [details] Patch Clearing flags on attachment: 309393 Committed r216474: <http://trac.webkit.org/changeset/216474>
WebKit Commit Bot
Comment 3 2017-05-08 19:46:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.