Bug 171812

Summary:

CoreAudioSharedUnit should own its configuration parameters

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Media

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, eric.carlson, jer.noble, jonlee, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description youenn fablet 2017-05-08 10:32:45 PDT

Currently, it takes its parameters (sampleRate, echoCancellation...) from its first client.
But it should really be the last client having either been created or been applying constraints.

Comment 1 youenn fablet 2017-05-08 10:40:09 PDT

Created attachment 309377 [details]
Patch

Comment 2 Radar WebKit Bug Importer 2017-05-08 10:51:34 PDT

<rdar://problem/32053243>

Comment 3 Build Bot 2017-05-08 10:53:44 PDT

Attachment 309377 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:253:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 youenn fablet 2017-05-08 10:56:00 PDT

Created attachment 309380 [details]
Patch

Comment 5 Eric Carlson 2017-05-08 12:22:58 PDT

Comment on attachment 309380 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309380&action=review

> Source/WebCore/ChangeLog:11
> +        Adding sampleRate, volume and echoCancellation parameters to the shared audio unit.
> +        Setting default values when creating the shared audio unit and using those for the creation of new sources.

Nit: "Adding" => "Add", "Setting" => "Set", "using" => "use"

> Source/WebCore/ChangeLog:14
> +        Checking valid sample rates when trying to apply a sample rate.

Nit: "Checking" => "Check"

Comment 6 youenn fablet 2017-05-08 14:43:05 PDT

Created attachment 309414 [details]
Patch

Comment 7 WebKit Commit Bot 2017-05-08 15:12:42 PDT

Comment on attachment 309414 [details]
Patch

Clearing flags on attachment: 309414

Committed r216455: <http://trac.webkit.org/changeset/216455>

Comment 8 WebKit Commit Bot 2017-05-08 15:12:44 PDT

All reviewed patches have been landed.  Closing bug.