| Summary: | Reduce PassRefPtr use | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | buildbot, cdumez, simon.fraser | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Alex Christensen
2017-05-08 09:54:41 PDT
Created attachment 309368 [details]
Patch
Attachment 309368 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 29 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 309368 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309368&action=review r=me with comments, please make sure all bots are happy. > Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:355 > + AVPlayerLayer *destinationPlayerLayer = static_cast<PlatformCALayerCocoa&>(newLayer.get()).avPlayerLayer(); Should be a downcast. > Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp:54 > visitedLinkTableControllerPtr = visitedLinkTableController.ptr(); This line seems useless? > Source/WebKit2/WebProcess/WebPage/WebOpenPanelResultListener.h:57 > RefPtr<WebCore::FileChooser> m_fileChooser; Should be a Ref<>. Created attachment 309371 [details]
Patch
Comment on attachment 309371 [details]
Patch
Same comments as before.
(In reply to Chris Dumez from comment #3) > > Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:355 > > + AVPlayerLayer *destinationPlayerLayer = static_cast<PlatformCALayerCocoa&>(newLayer.get()).avPlayerLayer(); > > Should be a downcast. That doesn't compile. > > > Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp:54 > > visitedLinkTableControllerPtr = visitedLinkTableController.ptr(); > > This line seems useless? It's needed in this case to set the pointer in the HashMap. Weird. We can't use ensure here, though, because the HashMap values are raw pointers, and we need to return a Ref here. Created attachment 309378 [details]
Patch
Created attachment 309384 [details]
Patch
Created attachment 309386 [details]
Patch
Created attachment 309392 [details]
Patch
|