Bug 171807 – [css-grid] Remove Blink-specific code for handling orthogonal grid items

• Component: New Bugs
• Status: RESOLVED FIXED

[Sergio Villar Senin]

[css-grid] Remove Blink-specific code for handling orthogonal grid items

[Sergio Villar Senin]

Created attachment 309365 [details]
Patch

[Sergio Villar Senin]

Committed r216574: <http://trac.webkit.org/changeset/216574>

[Javier Fernandez]

Comment on attachment 309365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309365&action=review

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:-763
> -

Even that the comment is confusing, because it mentions the pre-layout stuff that blink is doing on orthogonal flow boxes, the removed code had a different purpose. It was not only there to avoid further computation, but it's main goal was to avoid performing layouts during the intrinsic size computation. 

Now that these lines are gone, in case of computing column tracks based on orthogonal grid items size, we will use logicalHeightForChild, which will indeed laid out the grid item to figure out its actual size.

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:772
>      }

Ditto