Summary: | WebAssembly: don't just emit extended offset adds for patch | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | JF Bastien <jfbastien> | ||||
Component: | JavaScriptCore | Assignee: | JF Bastien <jfbastien> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, fpizlo, jfbastien, keith_miller, mark.lam, msaboff, saam | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 170215 | ||||||
Bug Blocks: | 159775 | ||||||
Attachments: |
|
Description
JF Bastien
2017-05-07 22:41:15 PDT
Created attachment 309346 [details] patch pizlo had said: (In reply to Filip Pizlo from comment #30) > Comment on attachment 309022 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309022&action=review > > > Source/JavaScriptCore/b3/air/AirLowerStackArgs.cpp:80 > > + if (isPatch && inst.admitsExtendedOffsetAddr(arg)) { > > I would drop the isPatch check Comment on attachment 309346 [details]
patch
r=me
Comment on attachment 309346 [details] patch Clearing flags on attachment: 309346 Committed r216430: <http://trac.webkit.org/changeset/216430> All reviewed patches have been landed. Closing bug. |