Bug 171778

Summary: [iOS WK2] Make rotation tests more reliable
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, simon.fraser, thorton, wenson_hsieh
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Simon Fraser (smfr)
Reported 2017-05-06 15:49:04 PDT
[iOS WK2] Make rotation tests more reliable
Attachments
Patch (14.39 KB, patch)
2017-05-06 15:54 PDT, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2017-05-06 15:54:42 PDT
Created attachment 309301 [details] Patch
Build Bot
Comment 2 2017-05-06 15:57:26 PDT
Attachment 309301 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/ios/TestControllerIOS.mm:102: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Tools/WebKitTestRunner/ios/TestControllerIOS.mm:114: No space between ^ and block definition. [whitespace/brackets] [4] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 3 2017-05-06 19:54:36 PDT
https://webkit.org/b/171778
Simon Fraser (smfr)
Comment 4 2017-05-06 19:55:33 PDT
https://trac.webkit.org/r216335
Note You need to log in before you can comment on or make changes to this bug.