Bug 171766

Summary:

Remove Vibration API

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

WebCore Misc.

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, joepeck, sam, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=99029
https://bugs.webkit.org/show_bug.cgi?id=145917
https://bugs.webkit.org/show_bug.cgi?id=288846

Attachments:

Description	Flags
[PATCH] Proposed Fix	ap: review+, buildbot: commit-queue-
Archive of layout-test-results from ews116 for mac-elcapitan	none
[PATCH] For Bots	commit-queue: commit-queue-

Joseph Pecoraro

Reported 2017-05-05 19:09:03 PDT

Remove Vibration API - Not enabled by any ports - Tests are skipped by all ports - Unmaintained code

Attachments
[PATCH] Proposed Fix (61.48 KB, patch) 2017-05-05 19:11 PDT, Joseph Pecoraro	ap: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews116 for mac-elcapitan (1.68 MB, application/zip) 2017-05-06 00:39 PDT, Build Bot	no flags	Details
[PATCH] For Bots (61.95 KB, patch) 2017-05-09 11:49 PDT, Joseph Pecoraro	commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2017-05-05 19:11:19 PDT

Created attachment 309258 [details] [PATCH] Proposed Fix I'll let the bots chew on this as well as a local build. Perhaps we should run this by webkit-dev?

Alexey Proskuryakov

Comment 2 2017-05-05 21:32:54 PDT

Comment on attachment 309258 [details] [PATCH] Proposed Fix Perhaps. rs=me anyway.

Build Bot

Comment 3 2017-05-06 00:39:53 PDT

Comment on attachment 309258 [details] [PATCH] Proposed Fix Attachment 309258 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3685229 New failing tests: fast/dom/Window/redirect-with-timer.html

Build Bot

Comment 4 2017-05-06 00:39:54 PDT

Created attachment 309277 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Joseph Pecoraro

Comment 5 2017-05-09 11:36:49 PDT

Now needs: LayoutTests/platform/wpe/TestExpectations 23:Bug(WPE) vibration/ [ Skip ]

Joseph Pecoraro

Comment 6 2017-05-09 11:40:21 PDT

Started a webkit-dev thread: https://lists.webkit.org/pipermail/webkit-dev/2017-May/029029.html

Joseph Pecoraro

Comment 7 2017-05-09 11:49:10 PDT

Created attachment 309518 [details] [PATCH] For Bots

WebKit Commit Bot

Comment 8 2017-05-11 14:27:24 PDT

Comment on attachment 309518 [details] [PATCH] For Bots Rejecting attachment 309518 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 309518, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: r is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit + a523d35...5a6ab82 master -> origin/master (forced update) Current branch master is up to date. Total errors found: 0 in 1 files Full output: http://webkit-queues.webkit.org/results/3720821

Joseph Pecoraro

Comment 9 2017-05-11 14:46:19 PDT

<https://trac.webkit.org/changeset/216696/webkit>

Note You need to log in before you can comment on or make changes to this bug.