Summary: | Make it possible to test rotation in iOS WebKitTestRunner | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | buildbot, simon.fraser, thorton, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2017-05-05 15:49:55 PDT
Created attachment 309231 [details]
Patch
Attachment 309231 [details] did not pass style-queue:
ERROR: Tools/TestRunnerShared/UIScriptContext/UIScriptController.cpp:46: Multi line control clauses should use braces. [whitespace/braces] [4]
ERROR: Tools/TestRunnerShared/UIScriptContext/UIScriptController.cpp:49: Multi line control clauses should use braces. [whitespace/braces] [4]
ERROR: Tools/TestRunnerShared/UIScriptContext/UIScriptController.cpp:52: Multi line control clauses should use braces. [whitespace/braces] [4]
ERROR: Tools/TestRunnerShared/UIScriptContext/UIScriptController.cpp:55: Multi line control clauses should use braces. [whitespace/braces] [4]
ERROR: Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:122: Multi line control clauses should use braces. [whitespace/braces] [4]
ERROR: Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:127: No space between ^ and block definition. [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:137: Multi line control clauses should use braces. [whitespace/braces] [4]
ERROR: Tools/WebKitTestRunner/ios/UIKitSPI.h:40: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Tools/WebKitTestRunner/ios/UIKitSPI.h:70: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/ios/UIKitSPI.h:71: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:558: Multi line control clauses should use braces. [whitespace/braces] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:582: No space between ^ and block definition. [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:598: No space between ^ and block definition. [whitespace/brackets] [4]
Total errors found: 13 in 20 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 309231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309231&action=review > LayoutTests/fast/events/ios/rotation/basic-rotation-expected.txt:10 > +PASS window.innerWidth is 320 > +PASS window.innerHeight is 320 Please check these in as failures. |