Summary: | LayoutTest js/Promise-types.html is a flaky failure (Unhandled Promise Rejection messages) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||
Component: | New Bugs | Assignee: | Ryan Haddad <ryanhaddad> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, commit-queue, fpizlo, jlewis3, joepeck | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryan Haddad
2017-05-05 11:16:20 PDT
I'm guessing this test needs the same treatment applied to the tests in https://bugs.webkit.org/show_bug.cgi?id=171445 reproduced locally on Sierra debug with: run-webkit-tests js/Promise-types.html -f --iterations=500 --no-retry-failure -g --debug (In reply to Ryan Haddad from comment #1) > I'm guessing this test needs the same treatment applied to the tests in > https://bugs.webkit.org/show_bug.cgi?id=171445 Correct that would be sufficient. Created attachment 310600 [details]
Patch
Comment on attachment 310600 [details]
Patch
r=me
Comment on attachment 310600 [details] Patch Clearing flags on attachment: 310600 Committed r217140: <http://trac.webkit.org/changeset/217140> All reviewed patches have been landed. Closing bug. My change managed to break the test when it is run as part of the JSC tests: jsc-layout-tests.yaml/js/script-tests/Promise-types.js.layout-no-cjit: Exception: ReferenceError: Can't find variable: window https://build.webkit.org/builders/Apple%20Sierra%20Release%20JSC%20%28Tests%29/builds/1434 (In reply to Ryan Haddad from comment #8) > My change managed to break the test when it is run as part of the JSC tests: > > jsc-layout-tests.yaml/js/script-tests/Promise-types.js.layout-no-cjit: > Exception: ReferenceError: Can't find variable: window > > > https://build.webkit.org/builders/ > Apple%20Sierra%20Release%20JSC%20%28Tests%29/builds/1434 Ahh yes, I should have realized. You could actually just do: onunhandledrejection = () => false; Without the `window.` portion. Comment on attachment 310600 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310600&action=review > LayoutTests/js/script-tests/Promise-types.js:10 > +// Silence unhandled rejection messages. > +window.onunhandledrejection = () => false; > + This caused the test to always fail in jsc tests. (In reply to Joseph Pecoraro from comment #9) > (In reply to Ryan Haddad from comment #8) > > My change managed to break the test when it is run as part of the JSC tests: > > > > jsc-layout-tests.yaml/js/script-tests/Promise-types.js.layout-no-cjit: > > Exception: ReferenceError: Can't find variable: window > > > > > > https://build.webkit.org/builders/ > > Apple%20Sierra%20Release%20JSC%20%28Tests%29/builds/1434 > > Ahh yes, I should have realized. > > You could actually just do: > > onunhandledrejection = () => false; > > Without the `window.` portion. I verified that making this change fixes the test failure when run locally. I will land a follow up fix to correct my error. Fixed in https://trac.webkit.org/r217155 |