Bug 171735
| Summary: | [GTK] Add WebKitWebView can-go-back and can-go-forward properties | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sébastien Wilmet <swilmet> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Enhancement | CC: | aperez, bugs-noreply, janousek.jiri, mcatanzaro |
| Priority: | P3 | Keywords: | Gtk |
| Version: | Other | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Sébastien Wilmet
It would be nice to have WebKitWebView can-go-back and can-go-forward boolean properties, to update the sensitivity of previous/next buttons.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sébastien Wilmet
See the following bug in Devhelp to know why I've filed this bug.
https://bugzilla.gnome.org/show_bug.cgi?id=775175
Michael Catanzaro
Hm, this should be easy to implement by connecting to the "changed" signal of the WebKitBackForwardList and then calling webkit_web_view_can_go_back() and webkit_web_view_can_go_forward(). That's what Epiphany does, and it's what you could do in Devhelp in the meantime.
Sébastien Wilmet
Thanks for the hint, the "changed" signal of WebKitBackForwardList is actually quite convenient to use. With the properties it would anyway not be possible to bind them directly to the GtkButtons sensitivity, because there are several tabs.
Adrian Perez
(In reply to Sébastien Wilmet from comment #3)
> Thanks for the hint, the "changed" signal of WebKitBackForwardList is
> actually quite convenient to use. With the properties it would anyway not be
> possible to bind them directly to the GtkButtons sensitivity, because there
> are several tabs.
Hi Sébastien! If I understand correctly, here you agreed that using
the ::changed signal and calculating whether the buttons should be
sensitive ended up being better, isn't it? If that's the case, then
I think we can close this as WONTFIX.
Sébastien Wilmet
Yes in Devhelp it's actually easier with the ::changed signal.
Adrian Perez
(In reply to Sébastien Wilmet from comment #5)
> Yes in Devhelp it's actually easier with the ::changed signal.
Great, thanks for closing the issue!