Bug 171734

Summary: Refactor / Clean up Element.idl
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, cmarcelo, darin, dbates, esprehn+autocc, kangil.han, kondapallykalyan, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2017-05-05 09:57:57 PDT
Refactor / Clean up Element.idl to align with the latest specification: - https://dom.spec.whatwg.org/#interface-element
Attachments
Patch (23.92 KB, patch)
2017-05-05 10:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-05-05 10:10:20 PDT
Created attachment 309181 [details] Patch
Sam Weinig
Comment 2 2017-05-05 10:30:16 PDT
Comment on attachment 309181 [details] Patch It's somewhat surprising to me that order in the IDL dictates enumeration order. I can't remember if that is defined or not. Perhaps we should reify in a sorted order?
Chris Dumez
Comment 3 2017-05-05 10:41:06 PDT
(In reply to Sam Weinig from comment #2) > Comment on attachment 309181 [details] > Patch > > It's somewhat surprising to me that order in the IDL dictates enumeration > order. I can't remember if that is defined or not. Perhaps we should reify > in a sorted order? Perhaps, we should check what WebIDL spec says. I do not know.
Chris Dumez
Comment 4 2017-05-05 10:41:53 PDT
@Sam: I have this small related patch if you have time to review: https://bugs.webkit.org/show_bug.cgi?id=171691
Chris Dumez
Comment 5 2017-05-05 10:51:16 PDT
(In reply to Chris Dumez from comment #3) > (In reply to Sam Weinig from comment #2) > > Comment on attachment 309181 [details] > > Patch > > > > It's somewhat surprising to me that order in the IDL dictates enumeration > > order. I can't remember if that is defined or not. Perhaps we should reify > > in a sorted order? > > Perhaps, we should check what WebIDL spec says. I do not know. I found https://heycam.github.io/webidl/#legacy-platform-object-property-enumeration which says: "This document does not define a complete property enumeration order for platform objects implementing interfaces (or for platform objects representing exceptions)."
Chris Dumez
Comment 6 2017-05-05 11:14:17 PDT
Comment on attachment 309181 [details] Patch Clearing flags on attachment: 309181 Committed r216251: <http://trac.webkit.org/changeset/216251>
Chris Dumez
Comment 7 2017-05-05 11:14:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.