Bug 171727
| Summary: | Commits in branches triggering builds in the bots now | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, bugs-noreply, clopez, lforschler |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Carlos Garcia Campos
As discussed in webkit-dev it seems that a change in the svn commit hooks made commits in GTK+ stable branches to be shown in the buildbot and triggering builds that don't affect trunk at all. We probably need changes in the hooks but also in the buildbot config. See for example:
https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20(Build)/builds/1366
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
I believe that Lucas fixed this yesterday.
We now once again use the correct function to parse branch from path in the hook. This function raises an exception when the change is on tag or a release, so no buildbot config changes were needed.