Bug 171724

Summary: [GTK] TestController timeout source callback should return G_SOURCE_REMOVE
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, lforschler, mcatanzaro
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2017-05-05 05:22:04 PDT
It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped.
Attachments
Patch (1.45 KB, patch)
2017-05-05 05:23 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-05-05 05:23:50 PDT
Created attachment 309165 [details] Patch
Michael Catanzaro
Comment 2 2017-05-05 05:43:40 PDT
Comment on attachment 309165 [details] Patch Wow. How much does this fix? Wouldn't this have caused full CPU usage for as long as the test controller is running?
Carlos Garcia Campos
Comment 3 2017-05-05 06:03:33 PDT
(In reply to Michael Catanzaro from comment #2) > Comment on attachment 309165 [details] > Patch > > Wow. > > How much does this fix? Wouldn't this have caused full CPU usage for as long > as the test controller is running? Yes, only for some time, fortunately the WTR is killed by the python script when it times out.
Carlos Garcia Campos
Comment 4 2017-05-05 06:20:26 PDT
Committed r216241: <http://trac.webkit.org/changeset/216241>
Note You need to log in before you can comment on or make changes to this bug.