Bug 171724 - [GTK] TestController timeout source callback should return G_SOURCE_REMOVE
Summary: [GTK] TestController timeout source callback should return G_SOURCE_REMOVE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2017-05-05 05:22 PDT by Carlos Garcia Campos
Modified: 2017-05-05 06:20 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.45 KB, patch)
2017-05-05 05:23 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-05-05 05:22:04 PDT 
It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped.
Comment 1 Carlos Garcia Campos 2017-05-05 05:23:50 PDT 
Created attachment 309165 [details]
Patch
Comment 2 Michael Catanzaro 2017-05-05 05:43:40 PDT 
Comment on attachment 309165 [details]
Patch

Wow.

How much does this fix? Wouldn't this have caused full CPU usage for as long as the test controller is running?
Comment 3 Carlos Garcia Campos 2017-05-05 06:03:33 PDT 
(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 309165 [details]
> Patch
> 
> Wow.
> 
> How much does this fix? Wouldn't this have caused full CPU usage for as long
> as the test controller is running?

Yes, only for some time, fortunately the WTR is killed by the python script when it times out.
Comment 4 Carlos Garcia Campos 2017-05-05 06:20:26 PDT 
Committed r216241: <http://trac.webkit.org/changeset/216241>