Bug 171713

Summary:

Web Automation: cookie-related commands don't work correctly

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Web Inspector

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, beidson, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review+

Description BJ Burg 2017-05-04 21:32:51 PDT

Comment 1 BJ Burg 2017-05-04 21:33:04 PDT

<rdar://problem/29829930>

Comment 2 BJ Burg 2017-05-04 21:38:04 PDT

Created attachment 309142 [details]
Patch

Comment 3 Alexey Proskuryakov 2017-05-04 22:31:34 PDT

Comment on attachment 309142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309142&action=review

> Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:826
> +        if (error != CallbackBase::Error::None)
> +            callback->sendFailure(STRING_FOR_PREDEFINED_ERROR_NAME(InternalError));
> +        else
> +            callback->sendSuccess();

It seems slightly better to start with success case - avoiding negation makes code a bit easier to understand.

Comment 4 BJ Burg 2017-05-05 12:31:27 PDT

Committed r216261: <http://trac.webkit.org/changeset/216261>