Bug 171702

Summary: API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, mark.lam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 171586    
Bug Blocks: 171800    
Attachments:
Description Flags
Crashlog
none
proposed patch. fpizlo: review+

Ryan Haddad
Reported 2017-05-04 17:54:13 PDT
Created attachment 309119 [details] Crashlog Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 TestWTF 0x00000001028f6882 TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188 (StringView.h:608) 1 TestWTF 0x00000001029b8092 testing::Test::Run() + 92 2 TestWTF 0x00000001029b8736 testing::internal::TestInfoImpl::Run() + 178 3 TestWTF 0x00000001029b8b2e testing::TestCase::Run() + 188 4 TestWTF 0x00000001029bc1b7 testing::internal::UnitTestImpl::RunAllTests() + 581 5 TestWTF 0x000000010292da43 TestWebKitAPI::TestsController::run(int, char**) + 131 (TestsController.cpp:80) 6 TestWTF 0x00000001029b0702 main + 349 (mainMac.mm:52) 7 libdyld.dylib 0x00007fff922c65ad start + 1 https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK1%20%28Tests%29/builds/1339/steps/run-api-tests/logs/stdio
Attachments
Crashlog (39.19 KB, text/plain)
2017-05-04 17:54 PDT, Ryan Haddad 		no flags
Details
proposed patch. (1.55 KB, patch)
2017-05-04 20:20 PDT, Mark Lam 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2017-05-04 20:12:14 PDT
I see the issue. I forgot to undo a testing change. I'll test the fix and check it in if all goes well.
Mark Lam
Comment 2 2017-05-04 20:20:51 PDT
Created attachment 309134 [details] proposed patch.
Mark Lam
Comment 3 2017-05-04 20:25:58 PDT
Thanks for the review. Landed in r216231: <http://trac.webkit.org/r216231>.
Note You need to log in before you can comment on or make changes to this bug.