Bug 171692

Summary: Use if instead of return early for 13 places in WebAVPlayerController
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jeremy Jones
Reported 2017-05-04 14:26:33 PDT
From feedback on https://bugs.webkit.org/show_bug.cgi?id=171592 > Source/WebCore/platform/ios/WebAVPlayerController.mm:433 > + UNUSED_PARAM(sender); > + if (!self.delegate) > + return; > + self.delegate->toggleMuted(); Nit: this could probably just drop the ! from the if and skip the return.
Attachments
Patch (5.03 KB, patch)
2017-05-04 16:54 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2017-05-04 16:54:18 PDT
Created attachment 309114 [details] Patch
WebKit Commit Bot
Comment 2 2017-05-04 17:57:54 PDT
Comment on attachment 309114 [details] Patch Clearing flags on attachment: 309114 Committed r216221: <http://trac.webkit.org/changeset/216221>
WebKit Commit Bot
Comment 3 2017-05-04 17:57:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.