Bug 171680

Summary: [GTK][JSCOnly] Implement memoryFootprint for Linux
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, cgarcia, clopez, cmarcelo, dbates, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch clopez: review+

Yusuke Suzuki
Reported 2017-05-04 12:01:15 PDT
[GTK][JSCOnly] Implement memoryFootprint for Linux
Attachments
Patch (3.30 KB, patch)
2017-05-04 12:03 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (3.29 KB, patch)
2017-05-04 12:10 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (3.41 KB, patch)
2017-05-04 12:21 PDT, Yusuke Suzuki 		clopez: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-05-04 12:03:20 PDT
Created attachment 309077 [details] Patch
Yusuke Suzuki
Comment 2 2017-05-04 12:10:55 PDT
Created attachment 309079 [details] Patch
Yusuke Suzuki
Comment 3 2017-05-04 12:21:01 PDT
Created attachment 309083 [details] Patch
Build Bot
Comment 4 2017-05-04 12:23:32 PDT
Attachment 309083 [details] did not pass style-queue: ERROR: Source/WTF/wtf/MemoryFootprint.cpp:74: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Alberto Lopez Perez
Comment 5 2017-05-04 12:43:07 PDT
Comment on attachment 309083 [details] Patch Amazing!
Yusuke Suzuki
Comment 6 2017-05-04 13:00:43 PDT
Committed r216201: <http://trac.webkit.org/changeset/216201>
Carlos Garcia Campos
Comment 7 2017-05-04 23:16:58 PDT
Could we use this in the memory pressure handler as the physical memory of MemoryUsage struct?
Yusuke Suzuki
Comment 8 2017-05-05 15:09:00 PDT
(In reply to Carlos Garcia Campos from comment #7) > Could we use this in the memory pressure handler as the physical memory of > MemoryUsage struct? Yes, we can use it. I'll upload the patch for that.
Note You need to log in before you can comment on or make changes to this bug.