Bug 171639

Summary: Maintain interaction information imageURL as a URL, not a string
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, sam, simon.fraser, wenson_hsieh
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tim Horton
Reported 2017-05-03 17:48:04 PDT
Maintain interaction information imageURL as a URL, not a string
Attachments
Patch (5.03 KB, patch)
2017-05-03 17:48 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2017-05-03 17:48:13 PDT
Created attachment 308993 [details] Patch
Sam Weinig
Comment 2 2017-05-03 17:58:10 PDT
Comment on attachment 308993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308993&action=review > Source/WebKit2/ChangeLog:4 > + Maintain interaction information imageURL as a URL, not a string > + https://bugs.webkit.org/show_bug.cgi?id=171639 Ok. But why? Just because it is better?
Tim Horton
Comment 3 2017-05-03 18:06:17 PDT
(In reply to Sam Weinig from comment #2) > Comment on attachment 308993 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=308993&action=review > > > Source/WebKit2/ChangeLog:4 > > + Maintain interaction information imageURL as a URL, not a string > > + https://bugs.webkit.org/show_bug.cgi?id=171639 > > Ok. But why? Just because it is better? Is that so bad? :) But no, there is a good reason (for url, not for imageURL, but no point changing one and not the other).
WebKit Commit Bot
Comment 4 2017-05-03 19:03:02 PDT
Comment on attachment 308993 [details] Patch Clearing flags on attachment: 308993 Committed r216168: <http://trac.webkit.org/changeset/216168>
WebKit Commit Bot
Comment 5 2017-05-03 19:03:03 PDT
All reviewed patches have been landed. Closing bug.
Sam Weinig
Comment 6 2017-05-04 10:51:52 PDT
(In reply to Tim Horton from comment #3) > (In reply to Sam Weinig from comment #2) > > Comment on attachment 308993 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=308993&action=review > > > > > Source/WebKit2/ChangeLog:4 > > > + Maintain interaction information imageURL as a URL, not a string > > > + https://bugs.webkit.org/show_bug.cgi?id=171639 > > > > Ok. But why? Just because it is better? > > Is that so bad? :) Nope. Consistency is a fine reason. > But no, there is a good reason (for url, not for > imageURL, but no point changing one and not the other). What was the reason?
Note You need to log in before you can comment on or make changes to this bug.