Summary: | Add support for reading and writing settings from UIProcess audio capture | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||
Component: | Media | Assignee: | youenn fablet <youennf> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, jer.noble, jonlee, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
youenn fablet
2017-05-03 16:38:51 PDT
Created attachment 308991 [details]
Patch
Comment on attachment 308991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308991&action=review > Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:306 > Nit: extra blank > Source/WebKit2/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:147 > + settings = source->settings(); Why is this necessary? Created attachment 309018 [details]
Rebasing patch
(In reply to youenn fablet from comment #3) > Created attachment 309018 [details] > Rebasing patch Plus some minor clean-up to CoreAudioCaptureSource. Let's see whether it compiles and passes tests. Created attachment 309216 [details]
Patch for landing
Created attachment 309272 [details]
Patch for landing
Created attachment 309324 [details]
Fixing start/stop and using last client
Created attachment 309419 [details]
Patch
Comment on attachment 309419 [details] Patch Clearing flags on attachment: 309419 Committed r216463: <http://trac.webkit.org/changeset/216463> All reviewed patches have been landed. Closing bug. |