Bug 171624

Summary: Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, commit-queue, ggaren, kling, mitz, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 171565    
Attachments:
Description Flags
WIP Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-05-03 15:27:13 PDT
WebPageProxy::processDidCrash() is called twice in case of termination due to resource limits after r216129.
Attachments
WIP Patch (34.02 KB, patch)
2017-05-03 19:03 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (49.25 KB, patch)
2017-05-03 19:16 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (49.31 KB, patch)
2017-05-05 10:00 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-05-03 19:03:40 PDT
Created attachment 309001 [details] WIP Patch
Chris Dumez
Comment 2 2017-05-03 19:16:23 PDT
Created attachment 309002 [details] Patch
Chris Dumez
Comment 3 2017-05-04 20:51:47 PDT
ping review?
mitz
Comment 4 2017-05-05 09:20:38 PDT
Comment on attachment 309002 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309002&action=review > Source/WebKit2/ChangeLog:3 > + Rename webProcessDidCrashWithReason delegate to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations “delegate” is a term normally used in Cocoa API. C APIs usually call these things “clients” and “client callbacks”.
Chris Dumez
Comment 5 2017-05-05 10:00:22 PDT
Created attachment 309180 [details] Patch
WebKit Commit Bot
Comment 6 2017-05-05 11:11:50 PDT
Comment on attachment 309180 [details] Patch Clearing flags on attachment: 309180 Committed r216249: <http://trac.webkit.org/changeset/216249>
WebKit Commit Bot
Comment 7 2017-05-05 11:11:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.