Bug 171621

Summary: Array.prototype.sort should also allow a null comparator
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 186458    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch
none
Patch for landing commit-queue: commit-queue-

Keith Miller
Reported 2017-05-03 14:47:43 PDT
Array.prototype.sort should also allow a null comparator
Attachments
Patch (3.04 KB, patch)
2017-05-03 14:49 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.74 KB, patch)
2017-05-03 14:57 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (2.73 KB, patch)
2017-05-03 14:58 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.18 KB, patch)
2017-05-03 16:05 PDT, Keith Miller 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2017-05-03 14:49:57 PDT
Created attachment 308958 [details] Patch
Michael Saboff
Comment 2 2017-05-03 14:54:50 PDT
Comment on attachment 308958 [details] Patch r=me
Keith Miller
Comment 3 2017-05-03 14:57:12 PDT
Created attachment 308960 [details] Patch for landing
Keith Miller
Comment 4 2017-05-03 14:58:58 PDT
Created attachment 308961 [details] Patch
Michael Saboff
Comment 5 2017-05-03 15:01:06 PDT
Comment on attachment 308961 [details] Patch r=me
Build Bot
Comment 6 2017-05-03 15:41:12 PDT
Comment on attachment 308961 [details] Patch Attachment 308961 [details] did not pass jsc-ews (mac): Output: http://webkit-queues.webkit.org/results/3667059 New failing tests: ChakraCore.yaml/ChakraCore/test/Array/array_sort.js.default stress/array-sort-bad-comparator.js.default
Keith Miller
Comment 7 2017-05-03 16:05:31 PDT
Created attachment 308979 [details] Patch for landing
WebKit Commit Bot
Comment 8 2017-05-03 16:48:56 PDT
Comment on attachment 308979 [details] Patch for landing Rejecting attachment 308979 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 308979, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 418395314e7756324668f7db19e Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc M Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDevice.mm M Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm M Source/WebCore/ChangeLog r216155 = 0107832155b32cb2e404fa1a472fff405a475adf (refs/remotes/origin/master) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/3667664
Keith Miller
Comment 9 2017-05-03 19:16:19 PDT
Committed r216169: <http://trac.webkit.org/changeset/216169>
Keith Miller
Comment 10 2017-05-05 11:26:51 PDT
rdar://problem/30757933
Yusuke Suzuki
Comment 11 2018-06-09 02:34:09 PDT
Is this still a issue? Looking at the kangax table, all the engines except JSC rejects `null` now.
Note You need to log in before you can comment on or make changes to this bug.