Bug 171612

Summary: Fix compilation with ICU 59.1
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: WebKit Misc.Assignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cgarcia, commit-queue, darin, keith_miller, mark.lam, mcatanzaro, mmaxfield, msaboff, saam, ysuzuki
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Konstantin Tokarev 2017-05-03 12:50:16 PDT
ICU 59.1 has broken source compatibility. Now it defines UChar as char16_t, which does not allow automatic type conversion from unsigned short in C++ code.
Comment 1 Konstantin Tokarev 2017-05-03 12:52:40 PDT
Created attachment 308941 [details]
Patch
Comment 2 Konstantin Tokarev 2017-05-03 12:55:04 PDT
Created attachment 308942 [details]
Patch
Comment 3 Mark Lam 2017-05-03 15:40:12 PDT
Comment on attachment 308942 [details]
Patch

r=me
Comment 4 Michael Catanzaro 2017-05-03 16:24:14 PDT
static_cast does not work...? Really? I think it should.
Comment 5 Konstantin Tokarev 2017-05-04 01:07:53 PDT
static_cast doesn't cast pointers to different types
Comment 6 Konstantin Tokarev 2017-05-04 01:08:21 PDT
s/different/unrelated/, sorry
Comment 7 WebKit Commit Bot 2017-05-04 08:33:45 PDT
Comment on attachment 308942 [details]
Patch

Clearing flags on attachment: 308942

Committed r216187: <http://trac.webkit.org/changeset/216187>
Comment 8 WebKit Commit Bot 2017-05-04 08:33:46 PDT
All reviewed patches have been landed.  Closing bug.