Bug 171612

Summary: Fix compilation with ICU 59.1
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: WebKit Misc.Assignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cgarcia, commit-queue, darin, keith_miller, mark.lam, mcatanzaro, mmaxfield, msaboff, saam, ysuzuki
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Konstantin Tokarev
Reported 2017-05-03 12:50:16 PDT
ICU 59.1 has broken source compatibility. Now it defines UChar as char16_t, which does not allow automatic type conversion from unsigned short in C++ code.
Attachments
Patch (6.58 KB, patch)
2017-05-03 12:52 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (6.96 KB, patch)
2017-05-03 12:55 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2017-05-03 12:52:40 PDT
Created attachment 308941 [details] Patch
Konstantin Tokarev
Comment 2 2017-05-03 12:55:04 PDT
Created attachment 308942 [details] Patch
Mark Lam
Comment 3 2017-05-03 15:40:12 PDT
Comment on attachment 308942 [details] Patch r=me
Michael Catanzaro
Comment 4 2017-05-03 16:24:14 PDT
static_cast does not work...? Really? I think it should.
Konstantin Tokarev
Comment 5 2017-05-04 01:07:53 PDT
static_cast doesn't cast pointers to different types
Konstantin Tokarev
Comment 6 2017-05-04 01:08:21 PDT
s/different/unrelated/, sorry
WebKit Commit Bot
Comment 7 2017-05-04 08:33:45 PDT
Comment on attachment 308942 [details] Patch Clearing flags on attachment: 308942 Committed r216187: <http://trac.webkit.org/changeset/216187>
WebKit Commit Bot
Comment 8 2017-05-04 08:33:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.