Bug 171607

Summary: Handle KVO updating of the "hasOnlySecureContent" before a page results in an HTTP auth challenge
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, commit-queue
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Brady Eidson
Reported 2017-05-03 11:08:58 PDT
Handle KVO updating of the "hasOnlySecureContent" before a page results in an HTTP auth challenge <rdar://problem/28867282>
Attachments
Patch (1.49 KB, patch)
2017-05-03 11:18 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (1.48 KB, patch)
2017-05-03 11:56 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2017-05-03 11:18:07 PDT
Created attachment 308930 [details] Patch
Andy Estes
Comment 2 2017-05-03 11:20:13 PDT
Comment on attachment 308930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308930&action=review > Source/WebKit2/UIProcess/PageLoadState.cpp:209 > + if (data.state == State::Provisional) > + return WebCore::protocolIs(data.provisionalURL, "https"); Feels like a blank line belongs at the end of this.
Brady Eidson
Comment 3 2017-05-03 11:56:40 PDT
Created attachment 308934 [details] Patch
WebKit Commit Bot
Comment 4 2017-05-03 12:27:09 PDT
Comment on attachment 308934 [details] Patch Clearing flags on attachment: 308934 Committed r216132: <http://trac.webkit.org/changeset/216132>
WebKit Commit Bot
Comment 5 2017-05-03 12:27:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.