Bug 171604

Summary: Cleanup: Remove out-of-date comment and null check from DocumentLoader::detachFromFrame()
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Page LoadingAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, buildbot, cdumez, japhet
Priority: P2    
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 186081    
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2017-05-03 09:45:50 PDT
We no longer want to passively allow DocumentLoader::detachFromFrame() to be called twice as it never makes sense to for it to be called twice and indicates a bug that we want to fix. A release assert in DocumentLoader::cancelPolicyCheckIfNeeded() (added in r187558) called by DocumentLoader::detachFromFrame() enforces this invariant. We should remove the unnecessary null check of DocumentLoader::m_frameand the comment that explains this null check from DocumentLoader::detachFromFrame().
Attachments
Patch (2.21 KB, patch)
2017-05-03 09:46 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2017-05-03 09:46:12 PDT
(In reply to Daniel Bates from comment #0) > [...] > the unnecessary null check of DocumentLoader::m_frameand the comment that > explains this null check from DocumentLoader::detachFromFrame(). *DocumentLoader::m_frame and
Daniel Bates
Comment 2 2017-05-03 09:46:52 PDT
Created attachment 308915 [details] Patch
Daniel Bates
Comment 3 2017-05-03 09:52:45 PDT
Comment on attachment 308915 [details] Patch Clearing flags on attachment: 308915 Committed r216119: <http://trac.webkit.org/changeset/216119>
Daniel Bates
Comment 4 2017-05-03 09:52:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.