Bug 171592

Summary: Add mute to WebPlaybackSessionModel.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: New BugsAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
jeremyj-wk: review-
Patch
none
Patch
none
Patch none

Jeremy Jones
Reported 2017-05-02 20:39:20 PDT
Add mute and increaseVolume and decreaseVolume to WebPlaybackSessionModel.
Attachments
Patch (27.06 KB, patch)
2017-05-02 20:45 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch (26.81 KB, patch)
2017-05-02 20:50 PDT, Jeremy Jones 		jeremyj-wk: review-
DetailsFormatted DiffDiff
Patch (26.08 KB, patch)
2017-05-03 17:10 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch (23.32 KB, patch)
2017-05-04 14:12 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch (23.28 KB, patch)
2017-05-04 14:18 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2017-05-02 20:45:06 PDT
Created attachment 308886 [details] Patch
Jeremy Jones
Comment 2 2017-05-02 20:45:52 PDT
rdar://problem/31814074
Jeremy Jones
Comment 3 2017-05-02 20:50:28 PDT
Created attachment 308887 [details] Patch
Jeremy Jones
Comment 4 2017-05-03 17:10:33 PDT
Created attachment 308990 [details] Patch
Jeremy Jones
Comment 5 2017-05-04 14:12:39 PDT
Created attachment 309100 [details] Patch
Jeremy Jones
Comment 6 2017-05-04 14:18:34 PDT
Created attachment 309102 [details] Patch
Jer Noble
Comment 7 2017-05-04 14:20:11 PDT
Comment on attachment 309102 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309102&action=review > Source/WebCore/platform/ios/WebAVPlayerController.mm:433 > + UNUSED_PARAM(sender); > + if (!self.delegate) > + return; > + self.delegate->toggleMuted(); Nit: this could probably just drop the ! from the if and skip the return.
WebKit Commit Bot
Comment 8 2017-05-04 16:18:51 PDT
Comment on attachment 309102 [details] Patch Clearing flags on attachment: 309102 Committed r216216: <http://trac.webkit.org/changeset/216216>
WebKit Commit Bot
Comment 9 2017-05-04 16:18:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.