Bug 171590

Summary: Use PassRefPtr less in CompositeEditCommand
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, commit-queue, darin, ggaren, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-05-02 19:44:37 PDT
Use PassRefPtr less in CompositeEditCommand.
Attachments
Patch (109.06 KB, patch)
2017-05-02 19:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (109.56 KB, patch)
2017-05-02 20:43 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (109.62 KB, patch)
2017-05-03 08:43 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-05-02 19:47:19 PDT
Created attachment 308881 [details] Patch
Build Bot
Comment 2 2017-05-02 19:48:16 PDT
Attachment 308881 [details] did not pass style-queue: ERROR: Source/WebCore/editing/ApplyStyleCommand.cpp:671: 'styleToApply' is incorrectly named. It should be named 'protector' or 'protectedStyle'. [readability/naming/protected] [4] ERROR: Source/WebCore/editing/ApplyStyleCommand.cpp:951: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 2 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 3 2017-05-02 20:43:54 PDT
Created attachment 308885 [details] Patch
Build Bot
Comment 4 2017-05-02 20:46:30 PDT
Attachment 308885 [details] did not pass style-queue: ERROR: Source/WebCore/editing/ApplyStyleCommand.cpp:671: 'styleToApply' is incorrectly named. It should be named 'protector' or 'protectedStyle'. [readability/naming/protected] [4] ERROR: Source/WebCore/editing/ApplyStyleCommand.cpp:951: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 2 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 5 2017-05-03 08:43:16 PDT
Created attachment 308907 [details] Patch
Build Bot
Comment 6 2017-05-03 08:45:35 PDT
Attachment 308907 [details] did not pass style-queue: ERROR: Source/WebCore/editing/ApplyStyleCommand.cpp:671: 'styleToApply' is incorrectly named. It should be named 'protector' or 'protectedStyle'. [readability/naming/protected] [4] ERROR: Source/WebCore/editing/ApplyStyleCommand.cpp:951: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 2 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 7 2017-05-03 11:41:51 PDT
Comment on attachment 308907 [details] Patch Clearing flags on attachment: 308907 Committed r216128: <http://trac.webkit.org/changeset/216128>
Chris Dumez
Comment 8 2017-05-03 11:41:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.