Bug 171568 – check-webkit-style should also keep js-test-post[-async].js in sync

• Component: Tools / Tests
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

check-webkit-style should also keep js-test-post[-async].js in sync after the fix in Bug 171424.

We should also add a test for map_functions_to_dict() in jstest.py since that method relies on a regular expression built out of bailing wire and duct tape to extract the function source out of a JavaScript file.  When it fails, we'll want to add a new test that fails to make it easier to fix.

[David Kilzer (:ddkilzer)]

Created attachment 308850 [details]
Patch v1

[Joseph Pecoraro]

Comment on attachment 308850 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=308850&action=review

r=me

> Tools/Scripts/webkitpy/style/checkers/jstest_unittest.py:31
> +class JSTestTestCase(unittest.TestCase):

Maybe JSTestCheckerTestCase? I dunno how these things need to be named.

[David Kilzer (:ddkilzer)]

Comment on attachment 308850 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=308850&action=review

>> Tools/Scripts/webkitpy/style/checkers/jstest_unittest.py:31
>> +class JSTestTestCase(unittest.TestCase):
> 
> Maybe JSTestCheckerTestCase? I dunno how these things need to be named.

I like that better so we don't have ...TestTest... in the name.
(I was cribbing off JSTestCase in js_unittest.py.)

[David Kilzer (:ddkilzer)]

Committed r216110: <http://trac.webkit.org/changeset/216110>