| Summary: | Only try to get sandbox extension handle for IndexedDB directory if it is set | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
| Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aestes, commit-queue, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Brady Eidson
2017-05-01 16:10:32 PDT
Created attachment 308784 [details]
Patch
Comment on attachment 308784 [details]
Patch
Is this API-testable?
(In reply to Andy Estes from comment #3) > Comment on attachment 308784 [details] > Patch > > Is this API-testable? No, but testing infrastructure already caught this! (NSLogging causing perf tests to fail) Comment on attachment 308784 [details] Patch Clearing flags on attachment: 308784 Committed r216053: <http://trac.webkit.org/changeset/216053> All reviewed patches have been landed. Closing bug. Question! Why didn't you apply the same change to all the other directories? (AppCache/MediaCache/MediaKeys/WebSQL)? (In reply to Tim Horton from comment #7) > Question! Why didn't you apply the same change to all the other directories? > (AppCache/MediaCache/MediaKeys/WebSQL)? Because: 1 - it wasn't happening to them 2 - IndexedDB directory can optionally be null, but I'm sure at least some of those always get default directories I'm guessing you're asking because one of my above answers is not true in some configuration. Make that configuration fail in a test, then we'll have to fix the test :) |