Bug 171520

Summary: Stop using strcpy() in WebProcess::registerWithStateDumper() in WebProcessCocoa.mm
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit2Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, bfulgham, buildbot, cdumez, commit-queue, eric.carlson, ggaren, kling, krollin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 171494    
Bug Blocks:    
Attachments:
Description Flags
Patch v1
none
Patch v2
none
Archive of layout-test-results from ews122 for ios-simulator-wk2 none

Description David Kilzer (:ddkilzer) 2017-05-01 15:49:24 PDT 
$ ./Tools/Scripts/check-webkit-style --filter="-,+security/" Source/WebKit2
[GTK warnings elided]
ERROR: Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:286:  Almost always, snprintf is better than strcpy.  [security/printf] [4]
Total errors found: 1 in 2838 files

Found via re-enabled checkers from Bug 171494.
Comment 1 David Kilzer (:ddkilzer) 2017-05-01 15:53:29 PDT 
Created attachment 308780 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2017-05-02 02:53:23 PDT 
Created attachment 308812 [details]
Patch v2
Comment 3 Build Bot 2017-05-02 04:59:13 PDT 
Comment on attachment 308812 [details]
Patch v2

Attachment 308812 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3657200

New failing tests:
compositing/absolute-inside-out-of-view-fixed.html
Comment 4 Build Bot 2017-05-02 04:59:14 PDT 
Created attachment 308816 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 5 Chris Dumez 2017-05-02 13:52:56 PDT 
Comment on attachment 308812 [details]
Patch v2

r=me
Comment 6 WebKit Commit Bot 2017-05-02 14:25:02 PDT 
Comment on attachment 308812 [details]
Patch v2

Clearing flags on attachment: 308812

Committed r216095: <http://trac.webkit.org/changeset/216095>
Comment 7 WebKit Commit Bot 2017-05-02 14:25:03 PDT 
All reviewed patches have been landed.  Closing bug.