Bug 171514

Summary: [Cocoa] Replace uses of [get…Class() alloc] in Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebCore Misc.Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED WONTFIX    
Severity: Normal CC: cdumez, ggaren, mitz, sam, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 146862, 171486    
Bug Blocks:    
Attachments:
Description Flags
Patch v1 ddkilzer: review-

David Kilzer (:ddkilzer)
Reported 2017-05-01 14:27:47 PDT
$ ./Tools/Scripts/check-webkit-style --filter=-,+runtime/soft-linked-alloc Source/WebCore ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:447: Using +alloc with a soft-linked class. Use allocWebAVPictureInPicturePlayerLayerViewInstance() instead. [runtime/soft-linked-alloc] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:616: Using +alloc with a soft-linked class. Use allocWebAVPlayerLayerViewInstance() instead. [runtime/soft-linked-alloc] [4] Total errors found: 2 in 8492 files
Attachments
Patch v1 (2.28 KB, patch)
2017-05-01 14:35 PDT, David Kilzer (:ddkilzer) 		ddkilzer: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2017-05-01 14:35:04 PDT
Created attachment 308769 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 2 2017-05-01 15:37:52 PDT
Oh dear, I wonder why WebAVPictureInPicturePlayerLayerView and WebAVPlayerLayerView were soft-linked differently here? <https://trac.webkit.org/r187044>
David Kilzer (:ddkilzer)
Comment 3 2017-05-01 15:41:03 PDT
(In reply to David Kilzer (:ddkilzer) from comment #2) > Oh dear, I wonder why WebAVPictureInPicturePlayerLayerView and > WebAVPlayerLayerView were soft-linked differently here? > > <https://trac.webkit.org/r187044> Ah, for compatibility reasons. Okay, there's nothing to do here.
Note You need to log in before you can comment on or make changes to this bug.