Bug 171513

Summary:

API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

New Bugs

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, beidson, commit-queue, jlewis3, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=171422

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Ryan Haddad

Reported 2017-05-01 14:20:18 PDT

[ios-simulator] API test WebKit2.WebsiteDataStoreCustomPaths is failing FAIL WebKit2.WebsiteDataStoreCustomPaths /Volumes/Data/slave/ios-simulator-10-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:126 Value of: [[NSFileManager defaultManager] fileExistsAtPath:cookieStoragePath.path] Actual: true Expected: false https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20WK2%20%28Tests%29/builds/1033

Attachments
Patch (2.40 KB, patch) 2017-05-04 14:00 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (4.09 KB, patch) 2017-05-05 16:02 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (4.16 KB, patch) 2017-05-05 16:16 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (5.60 KB, patch) 2017-05-05 16:25 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Ryan Haddad

Comment 1 2017-05-01 14:22:21 PDT

This seems to have started with http://trac.webkit.org/changeset/215941

Ryan Haddad

Comment 2 2017-05-02 15:27:12 PDT

Brady, do you have time to take a look at this?

Brady Eidson

Comment 3 2017-05-02 15:49:43 PDT

(In reply to Ryan Haddad from comment #2) > Brady, do you have time to take a look at this? In a little bit.

Radar WebKit Bug Importer

Comment 4 2017-05-03 17:21:20 PDT

<rdar://problem/31977294>

Brady Eidson

Comment 5 2017-05-03 19:45:12 PDT

I can get to this tomorrow afternoon - In meantime somebody with a fresh checkout (I don't have one available tonight) can just wrap the entire test with an #if PLATFORM(MAC) to stop it messing up iOS bots

Brady Eidson

Comment 6 2017-05-04 14:00:22 PDT

Created attachment 309099 [details] Patch

WebKit Commit Bot

Comment 7 2017-05-04 14:42:26 PDT

Comment on attachment 309099 [details] Patch Clearing flags on attachment: 309099 Committed r216210: <http://trac.webkit.org/changeset/216210>

WebKit Commit Bot

Comment 8 2017-05-04 14:42:28 PDT

All reviewed patches have been landed. Closing bug.

Brady Eidson

Comment 9 2017-05-04 15:14:06 PDT

That was just to skip the test for now - This bug still needs to remain open.