Bug 171509

Summary: fix check-webkit-style errors in webkitpy about two blank lines before class definitions
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, buildbot, commit-queue, dbates, dewei_zhu, glenn, lforschler
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
none
Updated patch. none

Aakash Jain
Reported 2017-05-01 13:08:38 PDT
check-webkit-style emits errors in few files in webkitpy about not having two blank lines before class declaration. e.g.: ERROR: Tools/Scripts/webkitpy/style/checkers/featuredefines.py:40: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Tools/Scripts/webkitpy/port/device.py:25: expected 2 blank lines, found 1 [pep8/E302] [5]
Attachments
Proposed patch (6.94 KB, patch)
2017-05-01 13:14 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Updated patch. (7.13 KB, patch)
2017-05-01 13:28 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2017-05-01 13:08:50 PDT
https://www.python.org/dev/peps/pep-0008/#blank-lines "Surround top-level function and class definitions with two blank lines. Method definitions inside a class are surrounded by a single blank line."
Aakash Jain
Comment 2 2017-05-01 13:14:57 PDT
Created attachment 308756 [details] Proposed patch
Aakash Jain
Comment 3 2017-05-01 13:28:23 PDT
Created attachment 308758 [details] Updated patch.
WebKit Commit Bot
Comment 4 2017-05-01 14:49:31 PDT
Comment on attachment 308758 [details] Updated patch. Clearing flags on attachment: 308758 Committed r216030: <http://trac.webkit.org/changeset/216030>
WebKit Commit Bot
Comment 5 2017-05-01 14:49:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.