Bug 171506

Summary: fix check-webkit-style errors in webkitpy about not having two spaces before inline comment
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, buildbot, commit-queue, dbates, dewei_zhu, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=66719
Attachments:
Description Flags
Proposed patch
none
Updated patch none

Aakash Jain
Reported 2017-05-01 12:29:33 PDT
check-webkit-style emits errors in few files in webkitpy about not having two spaces before inline comment. We should fix these. e.g.: ERROR: Tools/Scripts/webkitpy/style/checker.py:143: at least two spaces before inline comment [pep8/E261] [5] ERROR: Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:2826: at least two spaces before inline comment [pep8/E261] [5]
Attachments
Proposed patch (11.52 KB, patch)
2017-05-01 12:38 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Updated patch (12.04 KB, patch)
2017-11-02 17:41 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2017-05-01 12:38:40 PDT
Created attachment 308749 [details] Proposed patch
Build Bot
Comment 2 2017-05-01 12:40:51 PDT
Attachment 308749 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:419: [SCMTest._shared_test_reverse_diff] Instance of 'SCMTest' has no 'scm' member [pylint/E1101] [5] ERROR: Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:706: [SVNTest.test_create_patch_is_full_patch] Instance of 'SVNTest' has no 'svn_checkout_path' member [pylint/E1101] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3 2017-05-01 12:47:18 PDT
Comment on attachment 308749 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=308749&action=review Do we actually want this rule? It contradicts Webkit style <https://webkit.org/code-style-guidelines/#comments>. > Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:419 > + self._setup_webkittools_scripts_symlink(self.scm) # Git's apply_reverse_diff uses resolve-ChangeLogs It may be good to take this opportunity to add periods in the end of sentences.
Aakash Jain
Comment 4 2017-05-01 13:38:56 PDT
(In reply to Alexey Proskuryakov from comment #3) > Do we actually want this rule? It contradicts Webkit style <https://webkit.org/code-style-guidelines/#comments>. Should we modify the check-webkit-style script then?
Alexey Proskuryakov
Comment 5 2017-10-25 11:29:12 PDT
Seems worth discussing it on webkit-dev.
Aakash Jain
Comment 6 2017-11-02 17:41:59 PDT
Created attachment 325805 [details] Updated patch Following PEP8 guidelines https://www.python.org/dev/peps/pep-0008/#inline-comments
Build Bot
Comment 7 2017-11-02 17:45:00 PDT
Attachment 325805 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:419: [SCMTest._shared_test_reverse_diff] Instance of 'SCMTest' has no 'scm' member [pylint/E1101] [5] ERROR: Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:706: [SVNTest.test_create_patch_is_full_patch] Instance of 'SVNTest' has no 'svn_checkout_path' member [pylint/E1101] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 8 2017-11-07 14:33:45 PST
Comment on attachment 325805 [details] Updated patch Clearing flags on attachment: 325805 Committed r224548: <https://trac.webkit.org/changeset/224548>
WebKit Commit Bot
Comment 9 2017-11-07 14:33:46 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2017-11-15 13:12:11 PST
<rdar://problem/35568992>
Note You need to log in before you can comment on or make changes to this bug.