| Summary: | Remove support for legacy Notifications | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | commit-queue, jonlee, ryanhaddad | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 171714 | ||||||||||||||
| Bug Blocks: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Sam Weinig
2017-04-30 15:28:50 PDT
Created attachment 308703 [details]
Patch
I discussed this briefly with Jon Lee in the passed, and he was not against the idea on the condition that gmail's use of local notifications still worked. I checked, and gmail's use of local notifications works just fine without legacy notifications. Created attachment 308704 [details]
Patch
First patch didn't apply, but I am thinking the tools may be broken again, and not working for removed files :(. Maybe this second upload will prove me wrong. (In reply to Sam Weinig from comment #4) > First patch didn't apply, but I am thinking the tools may be broken again, > and not working for removed files :(. Maybe this second upload will prove me > wrong. Bummer. Filed https://bugs.webkit.org/show_bug.cgi?id=171488 to track the patch applying issue. Created attachment 308706 [details]
Patch
Attempting workout by not removing any directories, only the files within. Will need second pass to remove empty directories. Created attachment 308743 [details]
Patch
Committed r216206: <http://trac.webkit.org/changeset/216206> Re-opened since this is blocked by bug 171714 (In reply to WebKit Commit Bot from comment #11) > Re-opened since this is blocked by bug 171714 The rollout does appear to have stopped the LayoutTest crashes seen on the bots. Crashlog and details in: https://bugs.webkit.org/show_bug.cgi?id=171705 Created attachment 309564 [details]
Patch
Committed r216641: <http://trac.webkit.org/changeset/216641> Re-landed with fix to use ActiveDOMObject::stop, rather than ContextDestructionObserver::contextDestroyed as the override where we unregister the notification. |