Bug 171479 – Allow WPT server to serve specific WebKit tests

• Component: Tools / Tests
• Status: RESOLVED FIXED

[youenn fablet]

Either we can add a specific directory within imported/w3c/web-platform-tests or we can add a mount point to WPT server directly.

[youenn fablet]

Created attachment 308673 [details]
Patch

[youenn fablet]

Gave it a try at tweaking our py infrastructure, pretty straightforward in fact.
Sam, if you want to have a try at it...
Maybe we want to move in that direction, I am not totally sure.

[Ryosuke Niwa]

Comment on attachment 308673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308673&action=review

r=me provided we reach a consensus on webkit-dev for naming.

> Tools/ChangeLog:9
> +        It points to LayoutTests/wpt folder and is triggered on "/WebKit" urls.

These directory names and the mounting point should probably be discussed on webkit-dev.

[youenn fablet]

Created attachment 309851 [details]
Patch for landing

[Ryosuke Niwa]

Comment on attachment 309851 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=309851&action=review

> Tools/ChangeLog:9
> +        It points to LayoutTests/wpt folder and is triggered on "/WebKit" urls.

Wait, you're adding this to LayoutTests/http/tests/wpt now, right?

[youenn fablet]

(In reply to youenn fablet from comment #4)
> Created attachment 309851 [details]
> Patch for landing

Made the following changes:
- changed folder to http/wpt
- moved some tests from http/tests/fetch to http/wpt/fetch to ensure they run well
- added some unit py tests for the URI conversion part

[youenn fablet]

(In reply to Ryosuke Niwa from comment #5)
> Comment on attachment 309851 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=309851&action=review
> 
> > Tools/ChangeLog:9
> > +        It points to LayoutTests/wpt folder and is triggered on "/WebKit" urls.
> 
> Wait, you're adding this to LayoutTests/http/tests/wpt now, right?

Ah, forgot to update the change log...

[youenn fablet]

Created attachment 309852 [details]
Patch

[youenn fablet]

(In reply to youenn fablet from comment #7)
> (In reply to Ryosuke Niwa from comment #5)
> > Comment on attachment 309851 [details]
> > Patch for landing
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=309851&action=review
> > 
> > > Tools/ChangeLog:9
> > > +        It points to LayoutTests/wpt folder and is triggered on "/WebKit" urls.
> > 
> > Wait, you're adding this to LayoutTests/http/tests/wpt now, right?
> 
> Ah, forgot to update the change log...

I am adding to LayoutTests/http/wpt, LayoutTests/http/tests remains served by apache only.

[WebKit Commit Bot]

Comment on attachment 309852 [details]
Patch

Clearing flags on attachment: 309852

Committed r216725: <http://trac.webkit.org/changeset/216725>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.