Bug 171479

Summary: Allow WPT server to serve specific WebKit tests
Product: WebKit Reporter: youenn fablet <youennf>
Component: Tools / TestsAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, cdumez, commit-queue, glenn, joepeck, lforschler, rniwa, sam, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch none

Description youenn fablet 2017-04-29 11:06:07 PDT
Either we can add a specific directory within imported/w3c/web-platform-tests or we can add a mount point to WPT server directly.
Comment 1 youenn fablet 2017-04-29 11:09:49 PDT
Created attachment 308673 [details]
Patch
Comment 2 youenn fablet 2017-04-29 11:12:00 PDT
Gave it a try at tweaking our py infrastructure, pretty straightforward in fact.
Sam, if you want to have a try at it...
Maybe we want to move in that direction, I am not totally sure.
Comment 3 Ryosuke Niwa 2017-05-08 19:14:47 PDT
Comment on attachment 308673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308673&action=review

r=me provided we reach a consensus on webkit-dev for naming.

> Tools/ChangeLog:9
> +        It points to LayoutTests/wpt folder and is triggered on "/WebKit" urls.

These directory names and the mounting point should probably be discussed on webkit-dev.
Comment 4 youenn fablet 2017-05-11 19:48:49 PDT
Created attachment 309851 [details]
Patch for landing
Comment 5 Ryosuke Niwa 2017-05-11 19:49:42 PDT
Comment on attachment 309851 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=309851&action=review

> Tools/ChangeLog:9
> +        It points to LayoutTests/wpt folder and is triggered on "/WebKit" urls.

Wait, you're adding this to LayoutTests/http/tests/wpt now, right?
Comment 6 youenn fablet 2017-05-11 19:51:22 PDT
(In reply to youenn fablet from comment #4)
> Created attachment 309851 [details]
> Patch for landing

Made the following changes:
- changed folder to http/wpt
- moved some tests from http/tests/fetch to http/wpt/fetch to ensure they run well
- added some unit py tests for the URI conversion part
Comment 7 youenn fablet 2017-05-11 19:51:41 PDT
(In reply to Ryosuke Niwa from comment #5)
> Comment on attachment 309851 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=309851&action=review
> 
> > Tools/ChangeLog:9
> > +        It points to LayoutTests/wpt folder and is triggered on "/WebKit" urls.
> 
> Wait, you're adding this to LayoutTests/http/tests/wpt now, right?

Ah, forgot to update the change log...
Comment 8 youenn fablet 2017-05-11 19:52:30 PDT
Created attachment 309852 [details]
Patch
Comment 9 youenn fablet 2017-05-11 19:53:55 PDT
(In reply to youenn fablet from comment #7)
> (In reply to Ryosuke Niwa from comment #5)
> > Comment on attachment 309851 [details]
> > Patch for landing
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=309851&action=review
> > 
> > > Tools/ChangeLog:9
> > > +        It points to LayoutTests/wpt folder and is triggered on "/WebKit" urls.
> > 
> > Wait, you're adding this to LayoutTests/http/tests/wpt now, right?
> 
> Ah, forgot to update the change log...

I am adding to LayoutTests/http/wpt, LayoutTests/http/tests remains served by apache only.
Comment 10 WebKit Commit Bot 2017-05-11 20:16:23 PDT
Comment on attachment 309852 [details]
Patch

Clearing flags on attachment: 309852

Committed r216725: <http://trac.webkit.org/changeset/216725>
Comment 11 WebKit Commit Bot 2017-05-11 20:16:25 PDT
All reviewed patches have been landed.  Closing bug.