Bug 171436

Summary: [Win] Set CMake args in build-webkit
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, fujii.hironori, lforschler, pvollan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix
none
Patch
none
Patch none

Don Olmstead
Reported 2017-04-28 10:24:07 PDT
Currently any values passed in --cmakeargs to build-webkit are ignored on Windows builds.
Attachments
Fix (1.14 KB, patch)
2017-04-28 10:35 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (1.09 KB, patch)
2017-05-05 15:22 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (1.09 KB, patch)
2017-05-09 16:45 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-04-28 10:35:32 PDT
Created attachment 308554 [details] Fix
Per Arne Vollan
Comment 2 2017-05-03 23:34:20 PDT
Comment on attachment 308554 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=308554&action=review Looks good, but please remove the incorrect entries in the Changelog. > Tools/ChangeLog:9 > + (cMakeArgsFromFeatures): Deleted. This function have not been deleted. > Tools/ChangeLog:10 > + (writeCongrats): Deleted. Ditto.
Don Olmstead
Comment 3 2017-05-05 15:22:22 PDT
Created attachment 309222 [details] Patch I just manually removed the lines. The script seems to be confused since its all in the root.
Per Arne Vollan
Comment 4 2017-05-06 00:07:37 PDT
It seems the patch does not merge successfully on trunk.
Don Olmstead
Comment 5 2017-05-09 16:45:46 PDT
Created attachment 309561 [details] Patch
Per Arne Vollan
Comment 6 2017-05-10 02:35:29 PDT
Comment on attachment 309561 [details] Patch R=me.
WebKit Commit Bot
Comment 7 2017-05-10 03:04:40 PDT
Comment on attachment 309561 [details] Patch Clearing flags on attachment: 309561 Committed r216577: <http://trac.webkit.org/changeset/216577>
WebKit Commit Bot
Comment 8 2017-05-10 03:04:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.