Bug 171434

Summary: [macOS] WebPlaybackControlsManager needs to know when the selected text or audio track changes
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, bdakin, commit-queue, eric.carlson, jer.noble, sam, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andy Estes
Reported 2017-04-28 10:00:07 PDT
[macOS] WebPlaybackControlsManager needs to know when the selected text or audio track changes
Attachments
Patch (23.00 KB, patch)
2017-04-28 10:14 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (28.59 KB, patch)
2017-04-28 12:55 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2017-04-28 10:02:22 PDT
rdar://problem/31887922
Andy Estes
Comment 2 2017-04-28 10:14:10 PDT
Created attachment 308546 [details] Patch
Andy Estes
Comment 3 2017-04-28 11:34:29 PDT
Comment on attachment 308546 [details] Patch Taking a different approach after talking to Jer and Eric.
Andy Estes
Comment 4 2017-04-28 12:55:22 PDT
Created attachment 308578 [details] Patch
Eric Carlson
Comment 5 2017-04-28 13:03:47 PDT
Comment on attachment 308578 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308578&action=review > Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.mm:451 > + if (offItem && !trackMenuItemSelected && displayMode == MediaControlsHost::forcedOnlyKeyword()) Nice catch!
WebKit Commit Bot
Comment 6 2017-04-28 14:44:19 PDT
Comment on attachment 308578 [details] Patch Clearing flags on attachment: 308578 Committed r215948: <http://trac.webkit.org/changeset/215948>
WebKit Commit Bot
Comment 7 2017-04-28 14:44:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.