Summary: | [macOS] WebPlaybackControlsManager needs to know when the selected text or audio track changes | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||
Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, andersca, bdakin, commit-queue, eric.carlson, jer.noble, sam, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Andy Estes
2017-04-28 10:00:07 PDT
Created attachment 308546 [details]
Patch
Comment on attachment 308546 [details]
Patch
Taking a different approach after talking to Jer and Eric.
Created attachment 308578 [details]
Patch
Comment on attachment 308578 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308578&action=review > Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.mm:451 > + if (offItem && !trackMenuItemSelected && displayMode == MediaControlsHost::forcedOnlyKeyword()) Nice catch! Comment on attachment 308578 [details] Patch Clearing flags on attachment: 308578 Committed r215948: <http://trac.webkit.org/changeset/215948> All reviewed patches have been landed. Closing bug. |