Bug 171433

Summary: Adding a runtime flag specific to MediaDevices
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, eric.carlson, ggaren
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 171730    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2017-04-28 08:59:20 PDT
This allows toggling MediaDevices and getUserMedia at runtime
Attachments
Patch (30.77 KB, patch)
2017-04-28 09:09 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (29.81 KB, patch)
2017-04-28 09:10 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (25.24 KB, patch)
2017-04-28 10:18 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-04-28 09:09:21 PDT
Created attachment 308536 [details] Patch
youenn fablet
Comment 2 2017-04-28 09:10:12 PDT
Created attachment 308537 [details] Patch
youenn fablet
Comment 3 2017-04-28 10:18:47 PDT
Created attachment 308549 [details] Patch
Geoffrey Garen
Comment 4 2017-04-28 10:30:50 PDT
Comment on attachment 308549 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308549&action=review r=me > Source/WebCore/ChangeLog:11 > + Setting media devices runtime flag to false by default. I think we want this preference to be true by default. Usually, we turn on all web platform features by default.
youenn fablet
Comment 5 2017-04-28 13:15:23 PDT
(In reply to Geoffrey Garen from comment #4) > Comment on attachment 308549 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=308549&action=review > > r=me > > > Source/WebCore/ChangeLog:11 > > + Setting media devices runtime flag to false by default. > > I think we want this preference to be true by default. Usually, we turn on > all web platform features by default. It is only enabled in DRT/WTR at the moment, not in WK1 and WK2 WebViews. When it is fully ready, we should move to default=true.
WebKit Commit Bot
Comment 6 2017-04-28 13:42:44 PDT
Comment on attachment 308549 [details] Patch Clearing flags on attachment: 308549 Committed r215939: <http://trac.webkit.org/changeset/215939>
WebKit Commit Bot
Comment 7 2017-04-28 13:42:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.