Summary: | [GTK] Add GTK+ implementation of WebAutomationSession | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bburg, bugs-noreply, clopez, joepeck, mcatanzaro | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 171107, 171428 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Carlos Garcia Campos
2017-04-28 07:11:10 PDT
Created attachment 308528 [details]
Patch
This won't apply because it depends on two other patches.
Comment on attachment 308528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308528&action=review This looks good to me, though I cannot really assess bugs in usage of GTK platform specifics. You probably want a GTK reviewer too. > Source/WebKit2/UIProcess/Automation/WebAutomationSession.h:231 > + // GTK+ doesn't keep track of the active modifiers when using synthesizez events. Typo: synthesized. > Source/WebKit2/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:36 > +static inline unsigned modifiersToEventState(WebEvent::Modifiers modifiers) These probably don't need to be 'inline'. > Source/WebKit2/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:51 > +static inline unsigned mouseButtonToGdkButton(Inspector::Protocol::Automation::MouseButton button) Ditto. > Source/WebKit2/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:86 > +static void doMotionEvent(GtkWidget* widget, const WebCore::IntPoint& location, unsigned state) Just FYI, on Mac we don't interpolate intermediate mouse positions. We might do so once the Actions API is implemented since it naturally specifies a duration for transitions. Brian, this patch depends on bug #171107, could you cq+ the patch there when you are around to make sure it doesn't break anything on your side? Committed r216114: <http://trac.webkit.org/changeset/216114> |