Bug 171428 – [GTK] Add automation session API

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

Automation requires public API to ask the browser to create the web views, similar to the API for window.open(). I think it's also important that automation is disabled by default, so that applications have to enable it explicitly.

[Carlos Garcia Campos]

Created attachment 308520 [details]
Patch

[Carlos Garcia Campos]

../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp
../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp: In lambda function:
../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:67:83: error: no matching function for call to 'AutomationTest::setTarget(guint64&, <brace-enclosed initializer list>)'
                         test->setTarget(connectionID, { targetID, name, isPaired });
                                                                                   ^
../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:67:83: note: candidate is:
../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomatiFailed to run "['Tools/Scripts/build-webkit', '--release', '--gtk', '--update-gtk', '--makeargs="-j48"']" exit_code: 1

I guess it's once again the GCC version or something because it builds locally, I'll try to work around it :-/

[Carlos Garcia Campos]

Created attachment 308521 [details]
Try to fix EWS build

[Carlos Garcia Campos]

Created attachment 308523 [details]
Try to fix EWS build

[Carlos Garcia Campos]

Created attachment 308524 [details]
Try to fix EWS build

[Carlos Garcia Campos]

Created attachment 308525 [details]
Try to fix EWS build

I hate GCC

[Carlos Garcia Campos]

Created attachment 308526 [details]
Try to fix EWS build

Let's forget about the { } and go back to the old fashion way.

[Carlos Garcia Campos]

Now it complains about a different thing, and of course I have no idea what the problem is :-(

[Carlos Garcia Campos]

Created attachment 308527 [details]
Try to fix EWS build

[Carlos Alberto Lopez Perez]

Comment on attachment 308527 [details]
Try to fix EWS build

I have tested it, the tests work fine for me. The code also looks good to me.
Another reviewer should also approve this before landing giving that this adds new API.
(Setting cq- due to that: needs second review)

[Michael Catanzaro]

I didn't look at the code, but the API seems fine to me.

[Blaze Burg]

Comment on attachment 308527 [details]
Try to fix EWS build

Looks awesome!

[Carlos Garcia Campos]

Committed r216006: <http://trac.webkit.org/changeset/216006>