Summary: | Web Inspector: RTL: inherit system layout direction by default | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||
Component: | Web Inspector | Assignee: | BJ Burg <bburg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, dbates, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
BJ Burg
2017-04-27 16:14:46 PDT
Created attachment 308473 [details]
Patch
Comment on attachment 308473 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308473&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Setting.js:115 > - // FIXME: change initial value to 'system' once we are happy with RTL support. > - // This will cause Web Inspector to use the system user interface layout direction. > - layoutDirection: new WebInspector.Setting("layout-direction", "ltr"), > + layoutDirectionOverride: new WebInspector.Setting("layout-direction-override", "system"), I realize the storage name needs to change in order for us to get the new default value of "system" going forward. However I think WebInspector.settings.layoutDirection is way better than WebInspector.settings.layoutDirectionOverride. I suggest we keep that. This brings to light that in the future we should name settings that are in experimental stages with a storage name "...-experimental" so that when we turn it on by default and rename it we can get the better name when it graduates! Created attachment 308474 [details]
Patch
(In reply to Joseph Pecoraro from comment #3) > Comment on attachment 308473 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=308473&action=review > > r=me > > > Source/WebInspectorUI/UserInterface/Base/Setting.js:115 > > - // FIXME: change initial value to 'system' once we are happy with RTL support. > > - // This will cause Web Inspector to use the system user interface layout direction. > > - layoutDirection: new WebInspector.Setting("layout-direction", "ltr"), > > + layoutDirectionOverride: new WebInspector.Setting("layout-direction-override", "system"), > > I realize the storage name needs to change in order for us to get the new > default value of "system" going forward. > > However I think WebInspector.settings.layoutDirection is way better than > WebInspector.settings.layoutDirectionOverride. I suggest we keep that. > > This brings to light that in the future we should name settings that are in > experimental stages with a storage name "...-experimental" so that when we > turn it on by default and rename it we can get the better name when it > graduates! OK! Committed r215906: <http://trac.webkit.org/changeset/215906> (In reply to Joseph Pecoraro from comment #3) > This brings to light that in the future we should name settings that are in > experimental stages with a storage name "...-experimental" so that when we > turn it on by default and rename it we can get the better name when it > graduates! We could either: 1) Create an ExperimentalSetting class which adds the storage name. 2) Add an `experimental` property (default false) to Setting which does the same thing. Comment on attachment 308474 [details] Patch Clearing review flag as this patch was landed per comment 6. |