Bug 171372

Summary:

Move UUID from WebCore/platform to WTF

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Web Template Framework

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bburg, commit-queue, darin, mcatanzaro

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Updated patch	mcatanzaro: review+, commit-queue: commit-queue-

Description Carlos Garcia Campos 2017-04-27 06:49:03 PDT

UUID only contains createCanonicalUUIDString() that is platform independent and doesn't depend on anything from WebCore, only from WTF. I plan to use it in the GTK+ WebDriver implementation that doesn't link to WebCore.

Comment 1 Carlos Garcia Campos 2017-04-27 06:52:37 PDT

Created attachment 308386 [details]
Patch

Comment 2 Michael Catanzaro 2017-04-27 08:05:16 PDT

Every bot is red

Comment 3 Carlos Garcia Campos 2017-04-27 08:07:36 PDT

(In reply to Michael Catanzaro from comment #2)
> Every bot is red

No, style and bindings are green! :-)

Comment 4 Carlos Garcia Campos 2017-04-27 08:19:48 PDT

Created attachment 308391 [details]
Updated patch

I forgot to add the files to WTF makefile :-P

Comment 5 Michael Catanzaro 2017-04-27 08:52:16 PDT

Comment on attachment 308391 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308391&action=review

r=me if it passes EWS

> Tools/WebKitTestRunner/TestController.cpp:-1880
> -static String createCanonicalUUIDString()

Was this unused?

Comment 6 Carlos Garcia Campos 2017-04-27 09:04:55 PDT

(In reply to Michael Catanzaro from comment #5)
> Comment on attachment 308391 [details]
> Updated patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=308391&action=review
> 
> r=me if it passes EWS
> 
> > Tools/WebKitTestRunner/TestController.cpp:-1880
> > -static String createCanonicalUUIDString()
> 
> Was this unused?

No, it was duplicated, defined as static but alos included from WebCore, so this one was actually used because it was called with no namespace, but there's no reason to include the WebCore, WTF one and duplicate the implementation there.

Comment 7 Alex Christensen 2017-04-27 11:10:45 PDT

Comment on attachment 308391 [details]
Updated patch

cool

Comment 8 WebKit Commit Bot 2017-04-27 22:43:31 PDT

Comment on attachment 308391 [details]
Updated patch

Rejecting attachment 308391 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 308391, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
n.cpp
patching file Source/WebKit2/UIProcess/gtk/WaylandCompositor.cpp
patching file Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.cpp
patching file Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/WebKitTestRunner/TestController.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Michael Catanzaro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3624408

Comment 9 Carlos Garcia Campos 2017-04-27 23:30:28 PDT

Committed r215922: <http://trac.webkit.org/changeset/215922>